Use object shorthand syntax

This commit is contained in:
Kristjan ESPERANTO 2024-12-06 09:38:56 +01:00
parent d32466ce2c
commit 361f55bec1
2 changed files with 11 additions and 13 deletions

View file

@ -1,8 +1,5 @@
Module.register('MMM-pages', { Module.register('MMM-pages', {
// We require the older style of function declaration for compatibility
// reasons.
/** /**
* By default, we have don't pseudo-paginate any modules. We also exclude * By default, we have don't pseudo-paginate any modules. We also exclude
* the page indicator by default, in case people actually want to use the * the page indicator by default, in case people actually want to use the
@ -25,7 +22,7 @@ Module.register('MMM-pages', {
/** /**
* Apply any styles, if we have any. * Apply any styles, if we have any.
*/ */
getStyles: function () { getStyles () {
return ['pages.css']; return ['pages.css'];
}, },
@ -36,7 +33,7 @@ Module.register('MMM-pages', {
* @param {number} x The dividend * @param {number} x The dividend
* @param {number} n The divisor * @param {number} n The divisor
*/ */
mod: function (x, n) { mod (x, n) {
return (x % n + n) % n; return (x % n + n) % n;
}, },
@ -44,7 +41,7 @@ Module.register('MMM-pages', {
* Pseudo-constructor for our module. Makes sure that values aren't negative, * Pseudo-constructor for our module. Makes sure that values aren't negative,
* and sets the default current page to 0. * and sets the default current page to 0.
*/ */
start: function () { start () {
// Clamp homePage value to [0, num pages). // Clamp homePage value to [0, num pages).
if (this.config.homePage >= this.config.modules.length || this.config.homePage < 0) { if (this.config.homePage >= this.config.modules.length || this.config.homePage < 0) {
this.config.homePage = 0; this.config.homePage = 0;
@ -91,7 +88,7 @@ Module.register('MMM-pages', {
* @param {string} notification the notification ID * @param {string} notification the notification ID
* @param {number|string} payload the page to change to/by * @param {number|string} payload the page to change to/by
*/ */
notificationReceived: function (notification, payload) { notificationReceived (notification, payload) {
switch (notification) { switch (notification) {
case 'PAGE_CHANGED': case 'PAGE_CHANGED':
Log.log(`[MMM-pages] received a notification to change to page ${payload} of type ${typeof payload}.`); Log.log(`[MMM-pages] received a notification to change to page ${payload} of type ${typeof payload}.`);
@ -153,7 +150,7 @@ Module.register('MMM-pages', {
* @param {number} fallback the fallback value to use. Accepts negative * @param {number} fallback the fallback value to use. Accepts negative
* numbers. * numbers.
*/ */
changePageBy: function (amt, fallback) { changePageBy (amt, fallback) {
if (typeof amt !== 'number' && typeof fallback === 'undefined') { if (typeof amt !== 'number' && typeof fallback === 'undefined') {
Log.warn(`[MMM-pages] ${amt} is not a number!`); Log.warn(`[MMM-pages] ${amt} is not a number!`);
} }
@ -175,7 +172,7 @@ Module.register('MMM-pages', {
* Handles hiding the current page's elements and showing the next page's * Handles hiding the current page's elements and showing the next page's
* elements. * elements.
*/ */
updatePages: function () { updatePages () {
// Update if there's at least one page. // Update if there's at least one page.
if (this.config.modules.length !== 0) { if (this.config.modules.length !== 0) {
this.animatePageChange(); this.animatePageChange();
@ -194,7 +191,7 @@ Module.register('MMM-pages', {
* @param {string} [targetPageName] the name of the hiddenPage we want to show. * @param {string} [targetPageName] the name of the hiddenPage we want to show.
* Optional and only used when we want to switch to a hidden page * Optional and only used when we want to switch to a hidden page
*/ */
animatePageChange: function (targetPageName) { animatePageChange (targetPageName) {
let lockStringObj = {lockString: this.identifier}; let lockStringObj = {lockString: this.identifier};
if (!this.config.useLockString) { if (!this.config.useLockString) {
// Passing in an undefined object is equivalent to not passing it in at // Passing in an undefined object is equivalent to not passing it in at
@ -231,7 +228,7 @@ Module.register('MMM-pages', {
* *
* @param {number} delay the delay, in milliseconds. * @param {number} delay the delay, in milliseconds.
*/ */
resetTimerWithDelay: function (delay) { resetTimerWithDelay (delay) {
if (this.config.rotationTime > 0) { if (this.config.rotationTime > 0) {
// This timer is the auto rotate function. // This timer is the auto rotate function.
clearInterval(this.timer); clearInterval(this.timer);
@ -275,7 +272,7 @@ Module.register('MMM-pages', {
* *
* @param {boolean} isRotating the parameter, if you want to pause or resume. * @param {boolean} isRotating the parameter, if you want to pause or resume.
*/ */
setRotation: function (isRotating) { setRotation (isRotating) {
const stateBaseString = isRotating ? 'resum' : 'paus'; const stateBaseString = isRotating ? 'resum' : 'paus';
if (isRotating === this.rotationPaused) { if (isRotating === this.rotationPaused) {
Log.warn(`[MMM-pages] was asked to ${stateBaseString}e but rotation is already ${stateBaseString}ed!`); Log.warn(`[MMM-pages] was asked to ${stateBaseString}e but rotation is already ${stateBaseString}ed!`);
@ -296,7 +293,7 @@ Module.register('MMM-pages', {
* *
* @param {string} name the name of the hiddenPage we want to show * @param {string} name the name of the hiddenPage we want to show
*/ */
showHiddenPage: function (name) { showHiddenPage (name) {
// Only proceed if the named hidden page actually exists // Only proceed if the named hidden page actually exists
if (name in this.config.hiddenPages) { if (name in this.config.hiddenPages) {
this.animatePageChange(name); this.animatePageChange(name);

View file

@ -33,6 +33,7 @@ const config = [
'@stylistic/quotes': ['error', 'single'], '@stylistic/quotes': ['error', 'single'],
'@stylistic/multiline-comment-style': 'off', '@stylistic/multiline-comment-style': 'off',
'@stylistic/multiline-ternary': 'off', '@stylistic/multiline-ternary': 'off',
'object-shorthand': ['error', 'always']
}, },
} }
]; ];