Compare commits

...

2 commits

Author SHA1 Message Date
Kristjan ESPERANTO
fd3c1142b7 Add linter workflow 2024-12-10 20:32:20 +01:00
Kristjan ESPERANTO
00800b9ac4 Add callback to hide and show
The callback is only optional, if you don't use the options.
https://docs.magicmirror.builders/development/core-module-file.html#this-hide-speed-callback-options

Without this change you can see an error message in the browser console: "callback is not an optional parameter!"
2024-12-10 20:26:21 +01:00
2 changed files with 28 additions and 2 deletions

26
.github/workflows/automated-tests.yaml vendored Normal file
View file

@ -0,0 +1,26 @@
name: Automated Tests
on:
push:
branches: [master, develop]
pull_request:
branches: [master, develop]
permissions:
contents: read
jobs:
lint:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Check out repository code
uses: actions/checkout@v4
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 22
cache: npm
- name: Install dependencies
run: npm ci
- name: Check linting
run: npm run lint

View file

@ -212,13 +212,13 @@ Module.register('MMM-pages', {
MM.getModules()
.exceptWithClass(modulesToShow)
.enumerate(module => module.hide(animationTime, lockStringObj));
.enumerate(module => module.hide(animationTime, () => {}, lockStringObj));
// Shows all modules meant to be on the current page, after a small delay.
setTimeout(() => {
MM.getModules()
.withClass(modulesToShow)
.enumerate(module => module.show(animationTime, lockStringObj));
.enumerate(module => module.show(animationTime, () => {}, lockStringObj));
}, animationTime);
},