From 60f95a03589734a897b52b417c113bafead1b285 Mon Sep 17 00:00:00 2001 From: Edward Shen Date: Sat, 27 Feb 2021 19:01:01 -0500 Subject: [PATCH] better doc --- src/values.rs | 29 +---------------------------- 1 file changed, 1 insertion(+), 28 deletions(-) diff --git a/src/values.rs b/src/values.rs index 20eadb0..ec2feb0 100644 --- a/src/values.rs +++ b/src/values.rs @@ -1,6 +1,5 @@ //! Rust containers for valid `git-config` types. -use crate::parser::Event; use bstr::{BStr, ByteSlice}; #[cfg(feature = "serde")] use serde::{Serialize, Serializer}; @@ -43,7 +42,7 @@ use std::str::FromStr; /// assert_eq!(normalize(b"hello \"world\""), Cow::<[u8]>::Owned(b"hello world".to_vec())); /// ``` /// -/// Escaped quotes are ignored. +/// Escaped quotes are unescaped. /// /// ``` /// # use std::borrow::Cow; @@ -131,32 +130,6 @@ pub enum ValueEventConversionError { NoValue, } -// impl<'a, 'b> TryFrom<&'b [Event<'a>]> for Value<'a> { -// type Error = ValueEventConversionError; - -// fn try_from(events: &'b [Event<'a>]) -> Result { -// let mut v = vec![]; - -// for event in events { -// match event { -// Event::Value(v) => return Ok(Self::from(v.borrow())), -// Event::ValueNotDone(value) => v.extend(value.borrow()), -// Event::ValueDone(value) => { -// v.extend(value.borrow()); -// // return Ok(Self::from(v)); -// } -// _ => (), -// } -// } - -// if v.is_empty() { -// Err(Self::Error::NoValue) -// } else { -// Err(Self::Error::ValueNotDone) -// } -// } -// } - impl<'a> From<&'a str> for Value<'a> { fn from(s: &'a str) -> Self { if let Ok(bool) = Boolean::try_from(s) {