more functionality to mutablesection

src/file.rs

@@ -56,16 +56,22 @@ struct SectionId(usize);
 
 /// A opaque type that represents a mutable reference to a section.
 #[derive(PartialEq, Eq, Hash, PartialOrd, Ord, Debug)]
-pub struct MutableSection<'borrow, 'event>(&'borrow mut Vec<Event<'event>>);
+pub struct MutableSection<'borrow, 'event> {
+    section: &'borrow mut Vec<Event<'event>>,
+    implicit_newline: bool,
+    whitespace: usize,
+}
 
-// Immutable methods, effectively a deref into Section
+// Immutable methods, effectively a deref into Section. Can't use Deref trait
+// as there's some lifetime shenanigans that prevent us from matching the trait
+// parameters.
 impl<'borrow, 'event> MutableSection<'borrow, 'event> {
     /// Retrieves the last matching value in a section with the given key.
     /// Returns None if the key was not found.
     #[inline]
     #[must_use]
     pub fn value(&self, key: &Key) -> Option<Cow<'event, [u8]>> {
-        Section(self.0).value(key)
+        Section(self.section).value(key)
     }
 
     /// Retrieves the last matching value in a section with the given key, and
@@ -79,7 +85,7 @@ impl<'borrow, 'event> MutableSection<'borrow, 'event> {
         &self,
         key: &Key,
     ) -> Result<T, GitConfigError<'event>> {
-        Section(self.0).value_as(key)
+        Section(self.section).value_as(key)
     }
 
     /// Retrieves all values that have the provided key name. This may return
@@ -87,7 +93,7 @@ impl<'borrow, 'event> MutableSection<'borrow, 'event> {
     #[inline]
     #[must_use]
     pub fn values(&self, key: &Key) -> Vec<Cow<'event, [u8]>> {
-        Section(self.0).values(key)
+        Section(self.section).values(key)
     }
 
     /// Retrieves all values that have the provided key name. This may return
@@ -101,17 +107,24 @@ impl<'borrow, 'event> MutableSection<'borrow, 'event> {
         &self,
         key: &Key,
     ) -> Result<Vec<T>, GitConfigError<'event>> {
-        Section(self.0).values_as(key)
+        Section(self.section).values_as(key)
     }
 }
 
-// Mutable methods on a mutable section
 impl<'borrow, 'event> MutableSection<'borrow, 'event> {
-    /// Adds an entry to the end of this section
+    /// Adds an entry to the end of this section.
     pub fn push(&mut self, key: Key<'event>, value: Cow<'event, [u8]>) {
-        self.0.push(Event::Key(key));
+        if self.whitespace > 0 {
-        self.0.push(Event::KeyValueSeparator);
+            self.section
-        self.0.push(Event::Value(value));
+                .push(Event::Whitespace(" ".repeat(self.whitespace).into()));
+        }
+
+        self.section.push(Event::Key(key));
+        self.section.push(Event::KeyValueSeparator);
+        self.section.push(Event::Value(value));
+        if self.implicit_newline {
+            self.section.push(Event::Newline("\n".into()));
+        }
     }
 
     /// Removes all events until a key value pair is removed. This will also
@@ -119,12 +132,12 @@ impl<'borrow, 'event> MutableSection<'borrow, 'event> {
     pub fn pop(&mut self) -> Option<(Key, Cow<'event, [u8]>)> {
         let mut values = vec![];
         // events are popped in reverse order
-        while let Some(e) = self.0.pop() {
+        while let Some(e) = self.section.pop() {
             match e {
                 Event::Key(k) => {
                     // pop leading whitespace
-                    if let Some(Event::Whitespace(_)) = self.0.last() {
+                    if let Some(Event::Whitespace(_)) = self.section.last() {
-                        self.0.pop();
+                        self.section.pop();
                     }
 
                     if values.len() == 1 {
@@ -147,10 +160,43 @@ impl<'borrow, 'event> MutableSection<'borrow, 'event> {
         }
         None
     }
+
+    /// Adds a new line event. Note that you don't need to call this unless
+    /// you've disabled implicit newlines.
+    pub fn push_newline(&mut self) {
+        self.section.push(Event::Newline("\n".into()));
+    }
+
+    /// Enables or disables automatically adding newline events after adding
+    /// a value. This is enabled by default.
+    pub fn implicit_newline(&mut self, on: bool) {
+        self.implicit_newline = on;
+    }
+
+    /// Sets the number of spaces before the start of a key value. By default,
+    /// this is set to two. Set to 0 to disable adding whitespace before a key
+    /// value.
+    pub fn set_whitespace(&mut self, num: usize) {
+        self.whitespace = num;
+    }
+
+    /// Returns the number of whitespace this section will insert before the
+    /// beginning of a key.
+    pub const fn whitespace(&self) -> usize {
+        self.whitespace
+    }
 }
 
-// Internal methods that require exact indices for faster operations.
+// Internal methods that may require exact indices for faster operations.
 impl<'borrow, 'event> MutableSection<'borrow, 'event> {
+    fn new(section: &'borrow mut Vec<Event<'event>>) -> Self {
+        Self {
+            section,
+            implicit_newline: true,
+            whitespace: 2,
+        }
+    }
+
     fn get<'key>(
         &self,
         key: &Key<'key>,
@@ -163,7 +209,7 @@ impl<'borrow, 'event> MutableSection<'borrow, 'event> {
         // section_id is guaranteed to exist in self.sections, else we have a
         // violated invariant.
 
-        for event in &self.0[start..=end] {
+        for event in &self.section[start..=end] {
             match event {
                 Event::Key(event_key) if event_key == key => found_key = true,
                 Event::Value(v) if found_key => {
@@ -190,13 +236,13 @@ impl<'borrow, 'event> MutableSection<'borrow, 'event> {
     }
 
     fn delete(&mut self, start: usize, end: usize) {
-        self.0.drain(start..=end);
+        self.section.drain(start..=end);
     }
 
     fn set_value(&mut self, index: usize, key: Key<'event>, value: Vec<u8>) {
-        self.0.insert(index, Event::Value(Cow::Owned(value)));
+        self.section.insert(index, Event::Value(Cow::Owned(value)));
-        self.0.insert(index, Event::KeyValueSeparator);
+        self.section.insert(index, Event::KeyValueSeparator);
-        self.0.insert(index, Event::Key(key));
+        self.section.insert(index, Event::Key(key));
     }
 }
 
@@ -746,7 +792,7 @@ impl<'lookup, 'event> MutableMultiValue<'_, 'lookup, 'event> {
 /// with all values instead.
 ///
 /// [`get_raw_value`]: Self::get_raw_value
-#[derive(PartialEq, Eq, Clone, Debug)]
+#[derive(PartialEq, Eq, Clone, Debug, Default)]
 pub struct GitConfig<'a> {
     /// The list of events that occur before an actual section. Since a
     /// `git-config` file prohibits global values, this vec is limited to only
@@ -765,6 +811,12 @@ pub struct GitConfig<'a> {
 }
 
 impl<'event> GitConfig<'event> {
+    /// Constructs an empty `git-config` file.
+    #[must_use]
+    pub fn new() -> Self {
+        Self::default()
+    }
+
     /// Returns an interpreted value given a section, an optional subsection and
     /// key.
     ///
@@ -787,12 +839,12 @@ impl<'event> GitConfig<'event> {
     ///         a = 10k
     ///         c
     /// "#;
-    /// let git_config = GitConfig::try_from(config).unwrap();
+    /// let git_config = GitConfig::try_from(config)?;
     /// // You can either use the turbofish to determine the type...
     /// let a_value = git_config.value::<Integer>("core", None, "a")?;
     /// // ... or explicitly declare the type to avoid the turbofish
     /// let c_value: Boolean = git_config.value("core", None, "c")?;
-    /// # Ok::<(), GitConfigError>(())
+    /// # Ok::<(), Box<dyn std::error::Error>>(())
     /// ```
     ///
     /// # Errors
@@ -877,6 +929,11 @@ impl<'event> GitConfig<'event> {
     }
 
     /// Returns an immutable section reference.
+    ///
+    /// # Errors
+    ///
+    /// This function will return an error if the section and optional
+    /// subsection do not exist.
     pub fn section<'lookup>(
         &mut self,
         section_name: &'lookup str,
@@ -890,6 +947,11 @@ impl<'event> GitConfig<'event> {
     }
 
     /// Returns an mutable section reference.
+    ///
+    /// # Errors
+    ///
+    /// This function will return an error if the section and optional
+    /// subsection do not exist.
     pub fn section_mut<'lookup>(
         &mut self,
         section_name: &'lookup str,
@@ -898,23 +960,66 @@ impl<'event> GitConfig<'event> {
         let section_ids =
             self.get_section_ids_by_name_and_subname(section_name, subsection_name)?;
 
-        Ok(MutableSection(
+        Ok(MutableSection::new(
             self.sections.get_mut(section_ids.last().unwrap()).unwrap(),
         ))
     }
 
-    /// Adds a new section to config. This cannot fail.
+    /// Adds a new section to config. If a subsection name was provided, then
+    /// the generated header will use the modern subsection syntax. Returns a
+    /// reference to the new section for immediate editing.
+    ///
+    /// # Examples
+    ///
+    /// Creating a new empty section:
+    ///
+    /// ```
+    /// # use git_config::file::{GitConfig, GitConfigError};
+    /// # use std::convert::TryFrom;
+    /// let mut git_config = GitConfig::new();
+    /// let _section = git_config.new_section("hello", Some("world".into()));
+    /// assert_eq!(git_config.to_string(), "[hello \"world\"]\n");
+    /// ```
+    ///
+    /// Creating a new empty section and adding values to it:
+    ///
+    /// ```
+    /// # use git_config::file::{GitConfig, GitConfigError};
+    /// # use std::convert::TryFrom;
+    /// let mut git_config = GitConfig::new();
+    /// let mut section = git_config.new_section("hello", Some("world".into()));
+    /// section.push("a".into(), "b".as_bytes().into());
+    /// assert_eq!(git_config.to_string(), "[hello \"world\"]\n  a=b\n");
+    /// let _section = git_config.new_section("core", None);
+    /// assert_eq!(git_config.to_string(), "[hello \"world\"]\n  a=b\n[core]\n");
+    /// ```
     pub fn new_section(
         &mut self,
         section_name: impl Into<Cow<'event, str>>,
         subsection_name: impl Into<Option<Cow<'event, str>>>,
     ) -> MutableSection<'_, 'event> {
-        self.push_section(
+        let subsection_name = subsection_name.into();
-            Some(SectionHeaderName(section_name.into())),
+        let mut section = if subsection_name.is_some() {
-            subsection_name.into(),
+            self.push_section(
-            &mut Some(vec![]),
+                ParsedSectionHeader {
-        )
+                    name: SectionHeaderName(section_name.into()),
-        .unwrap()
+                    separator: Some(" ".into()),
+                    subsection_name,
+                },
+                vec![],
+            )
+        } else {
+            self.push_section(
+                ParsedSectionHeader {
+                    name: SectionHeaderName(section_name.into()),
+                    separator: None,
+                    subsection_name: None,
+                },
+                vec![],
+            )
+        };
+        section.push_newline();
+        section
     }
 
     /// Removes the section, returning the events it had, if any. If multiple
@@ -1020,7 +1125,7 @@ impl<'event> GitConfig<'event> {
             }
 
             return Ok(MutableValue {
-                section: MutableSection(self.sections.get_mut(section_id).unwrap()),
+                section: MutableSection::new(self.sections.get_mut(section_id).unwrap()),
                 key,
                 size,
                 index,
@@ -1349,54 +1454,52 @@ impl<'event> GitConfig<'event> {
     /// Adds a new section to the config file.
     fn push_section(
         &mut self,
-        current_section_name: Option<SectionHeaderName<'event>>,
+        // current_section_name: Option<SectionHeaderName<'event>>,
-        current_subsection_name: Option<Cow<'event, str>>,
+        // current_subsection_name: Option<Cow<'event, str>>,
-        maybe_section: &mut Option<Vec<Event<'event>>>,
+        header: ParsedSectionHeader<'event>,
-    ) -> Option<MutableSection<'_, 'event>> {
+        maybe_section: Vec<Event<'event>>,
-        if let Some(section) = maybe_section.take() {
+    ) -> MutableSection<'_, 'event> {
-            let new_section_id = SectionId(self.section_id_counter);
+        let new_section_id = SectionId(self.section_id_counter);
-            self.sections.insert(new_section_id, section);
+        self.section_headers.insert(new_section_id, header.clone());
-            let lookup = self
+        self.sections.insert(new_section_id, maybe_section);
-                .section_lookup_tree
+        let lookup = self.section_lookup_tree.entry(header.name).or_default();
-                .entry(current_section_name.unwrap())
-                .or_default();
 
-            let mut found_node = false;
+        let mut found_node = false;
-            if let Some(subsection_name) = current_subsection_name {
+        if let Some(subsection_name) = header.subsection_name {
-                for node in lookup.iter_mut() {
+            for node in lookup.iter_mut() {
-                    if let LookupTreeNode::NonTerminal(subsection) = node {
+                if let LookupTreeNode::NonTerminal(subsection) = node {
-                        found_node = true;
+                    found_node = true;
-                        subsection
+                    subsection
-                            // Clones the cow, not the inner borrowed str.
+                        // Clones the cow, not the inner borrowed str.
-                            .entry(subsection_name.clone())
+                        .entry(subsection_name.clone())
-                            .or_default()
+                        .or_default()
-                            .push(new_section_id);
+                        .push(new_section_id);
-                        break;
+                    break;
-                    }
-                }
-                if !found_node {
-                    let mut map = HashMap::new();
-                    map.insert(subsection_name, vec![new_section_id]);
-                    lookup.push(LookupTreeNode::NonTerminal(map));
-                }
-            } else {
-                for node in lookup.iter_mut() {
-                    if let LookupTreeNode::Terminal(vec) = node {
-                        found_node = true;
-                        vec.push(new_section_id);
-                        break;
-                    }
-                }
-                if !found_node {
-                    lookup.push(LookupTreeNode::Terminal(vec![new_section_id]))
                 }
             }
-            self.section_order.push_back(new_section_id);
+            if !found_node {
-            self.section_id_counter += 1;
+                let mut map = HashMap::new();
-            self.sections.get_mut(&new_section_id).map(MutableSection)
+                map.insert(subsection_name, vec![new_section_id]);
+                lookup.push(LookupTreeNode::NonTerminal(map));
+            }
         } else {
-            None
+            for node in lookup.iter_mut() {
+                if let LookupTreeNode::Terminal(vec) = node {
+                    found_node = true;
+                    vec.push(new_section_id);
+                    break;
+                }
+            }
+            if !found_node {
+                lookup.push(LookupTreeNode::Terminal(vec![new_section_id]))
+            }
         }
+        self.section_order.push_back(new_section_id);
+        self.section_id_counter += 1;
+        self.sections
+            .get_mut(&new_section_id)
+            .map(MutableSection::new)
+            .unwrap()
     }
 
     /// Returns the mapping between section and subsection name to section ids.
@@ -1471,57 +1574,40 @@ impl<'a> From<Parser<'a>> for GitConfig<'a> {
         };
 
         // Current section that we're building
-        let mut current_section_name: Option<SectionHeaderName<'_>> = None;
+        let mut prev_section_header = None;
-        let mut current_subsection_name: Option<Cow<'a, str>> = None;
+        let mut section_events: Vec<Event<'a>> = vec![];
-        let mut maybe_section: Option<Vec<Event<'a>>> = None;
 
         for event in parser.into_iter() {
             match event {
                 Event::SectionHeader(header) => {
-                    new_self.push_section(
+                    if let Some(prev_header) = prev_section_header.take() {
-                        current_section_name,
+                        new_self.push_section(prev_header, section_events);
-                        current_subsection_name,
+                    } else {
-                        &mut maybe_section,
+                        new_self.frontmatter_events = section_events;
-                    );
+                    }
-
+                    prev_section_header = Some(header);
-                    // Initialize new section
+                    section_events = vec![];
-                    // We need to store the new, current id counter, so don't
-                    // use new_section_id here and use the already incremented
-                    // section id value.
-                    new_self
-                        .section_headers
-                        .insert(SectionId(new_self.section_id_counter), header.clone());
-                    let (name, subname) = (header.name, header.subsection_name);
-                    maybe_section = Some(vec![]);
-                    current_section_name = Some(name);
-                    current_subsection_name = subname;
                 }
                 e @ Event::Key(_)
                 | e @ Event::Value(_)
                 | e @ Event::ValueNotDone(_)
                 | e @ Event::ValueDone(_)
-                | e @ Event::KeyValueSeparator => maybe_section
+                | e @ Event::KeyValueSeparator => section_events.push(e),
-                    .as_mut()
-                    .expect("Got a section-only event before a section")
-                    .push(e),
                 e @ Event::Comment(_) | e @ Event::Newline(_) | e @ Event::Whitespace(_) => {
-                    match maybe_section {
+                    section_events.push(e);
-                        Some(ref mut section) => section.push(e),
-                        None => new_self.frontmatter_events.push(e),
-                    }
                 }
             }
         }
 
         // The last section doesn't get pushed since we only push if there's a
         // new section header, so we need to call push one more time.
-        new_self.push_section(
+        if let Some(header) = prev_section_header {
-            current_section_name,
+            new_self.push_section(header, section_events);
-            current_subsection_name,
+        } else {
-            &mut maybe_section,
+            new_self.frontmatter_events = section_events;
-        );
+        }
 
-        new_self
+        dbg!(new_self)
     }
 }
 
@@ -1765,7 +1851,6 @@ mod mutable_multi_value {
             .get_raw_multi_value_mut("core", None, "a")
             .unwrap();
         values.set_string(0, "Hello".to_string());
-        dbg!(values);
         assert_eq!(
             git_config.to_string(),
             r#"[core]
@@ -2074,7 +2159,7 @@ mod from_parser {
 #[cfg(test)]
 mod get_raw_value {
     use super::{Cow, GitConfig, GitConfigError, TryFrom};
-    use crate::parser::{Key, SectionHeaderName};
+    use crate::parser::SectionHeaderName;
 
     #[test]
     fn single_section() {

src/parser.rs

@@ -222,6 +222,7 @@ generate_case_insensitive!(
     Cow<'a, str>,
     "Wrapper struct for section header names, since section headers are case-insensitive."
 );
+
 generate_case_insensitive!(
     Key,
     Cow<'a, str>,